Author | Lightnews

Janko Marohnić @janko.io · 2d

...and it's up 🤘

github.com/Shopify/ruby...

Reposted by Janko Marohnić

Stan Lo @st0012.dev · 2d

I'm excited to share that I became a Ruby committer today! A 10 year goal since RubyKaigi 2015.
Huge thanks to @bernsteinbear.com for the JIT mentorship and nomination, @k0kubun.com for years of guidance, and everyone who supported me along the way.
Looking forward to improving Ruby and its DX!

13 7 68

Janko Marohnić @janko.io · 2d

It reminds me of me with HTTP/2, where by the time I started getting it and looking how to support it, h3 had already came out 😄

Janko Marohnić @janko.io · 2d

Inline RBS is the only gradual typing for Ruby I can get behind.

Sorbet’s RBI was way too verbose, as it had to be valid Ruby, but at least it was inline. RBS was more compact, but required separate files.

Inline RBS is just comments, and I imagine it has advantages over YARD.

2 2

Janko Marohnić @janko.io · 3d

To be clear, I'm referring to `ActionController::Base._prefixes` method. It's technically public, but the name indicates it maybe shouldn't be used.

Janko Marohnić @janko.io · 3d

It seems I will do that in Ruby LSP land after all. I couldn't think of a sane interface for retrieving view prefixes from controller, and `_prefixes` seems kind of like private API anyway.

1

Janko Marohnić @janko.io · 3d

Given that retrieving arguments of a `render` call is fairly easy, it makes sense for me that both Ruby LSP Rails and Herb do it, just for different purposes.

Ruby LSP Rails would use it to follow partial names, while Herb would use it for linting. So, I imagine them having different code.

1 1

Janko Marohnić @janko.io · 3d

Absolutely, linting sounds like it should live entirely in the Herb language server. AFAIK Ruby LSP doesn't have knowledge of where we are in the ERB file.

Prism nodes contain location info, but I would assume they don't point to the actual location in the template.

1 1

Janko Marohnić @janko.io · 3d

Yeah, that sounds useful in scenarios where "go to definition" should lead to specific part of the HTML+ERB template.

In my case, I just link to the start of the partial file.

Janko Marohnić @janko.io · 3d

I like that Ruby LSP abstracts ERB away from me, so I only need to check the file extension. This could then theoretically work in pure Ruby templates as well, and possibly jbuilder, it's not tied to HTML+ERB files.

Is there an advantage of doing it within Herb?

1 1

Janko Marohnić @janko.io · 3d

I'm actually trying to do that for the remaining component – controller inheritance chain. Rails allows rendering partials from any ancestor directory, and I thought it's best to ask Rails for the directory list.

It can be composed with static analysis, but I'm missing AS inflector methods.

1 1

Janko Marohnić @janko.io · 3d

Like, this actually works 🤯

1 2

Janko Marohnić @janko.io · 3d

There are surprisingly many aspects to handle:

* positional or keyword (:partial) argument
* relative vs absolute paths
* layout partials
* spacer templates
* ERB template rendering non-ERB partial (e.g. Slim)
* controller inheritance chain
* variants

2 3

Janko Marohnić @janko.io · 3d

It seems I've developed a newfound interest for language servers 🙂

They have just unlocked for me recently. It started with a contribution to Stimulus LSP, afterwards I wanted to fix issues I've been experiencing with Ruby LSP.

Kudos to Shopify for solving difficult problems like indexing 🙇‍♂️

6

Janko Marohnić @janko.io · 3d

With all Ruby LSP fixes for workspace symbol search underway, I would like to take a stab at adding a new feature.

Rails.vim had a neat feature where you can follow render calls in view templates via `gf`. I'm exploring adding the same feature to Ruby LSP Rails via "go to definition" 🤞

1 9

Reposted by Janko Marohnić

Martin Emde @martinemde.com · 5d

What comes through loud and clear from Shan is the lack of respect for open source authors. She actually says it’s none of my business why I was removed from rubygems. I don’t know where you got the audacity but you should put it back. youtu.be/nKpo68g9dEk?...

Technology for Humans: Shan Cureton

YouTube video by reinteractive

youtu.be

3 8 32

Janko Marohnić @janko.io · 6d

We're using Chamber for application secrets/settings at work, and probably the only that's keeping me from switching to Rails credentials is the ability to override any value with an environment variable.

That's really a killer feature, both Chamber and AnyConfig support it.

Janko Marohnić @janko.io · 8d

Links for the mentioned Ruby LSP issues:

github.com/Shopify/ruby...
github.com/Shopify/ruby...
github.com/Shopify/ruby...

Improve workspace/symbol request's performance · Issue #2660 · Shopify/ruby-lsp

I have checked that this feature is not already implemented This feature does not exist Use case The performance of the global go to symbol in ruby-lsp is noticeably worse when not excluding any ge...

github.com

Janko Marohnić @janko.io · 8d

So, the reason why project symbol search isn't working reliably in Zed is that Ruby LSP:

1. returns malformed results for method aliases
2. doesn't support request cancellation (Zed doesn't debounce atm)
3. searches gems as well, which is 3.5x slower, and adds up because of 2.

1 2

Janko Marohnić @janko.io · 10d

It seems symbol search for ruby symbols might start working after github.com/Shopify/ruby... is fixed ✌️

It took me a while to track down the exact issue in github.com/zed-industri..., only to find out it's already been reported to Ruby LSP 😅

WorkspaceSymbol request are returning invalid response on method alias, unresolved method alias and constants and class variables · Issue #3781 · Shopify/ruby-lsp

Description Ruby LSP Information Ruby LSP WorkspaceSymbol Responses are not generated according to spec if index contains unresolved alias methods, unresolved constant aliases or class variables. A...

github.com

1

Janko Marohnić @janko.io · 10d

The 37signals team must be patting themselves on the back during this AWS outage 😄

6

Reposted by Janko Marohnić

Peter Zhu @peterzhu.ca · 12d

I wrote about some of my thoughts on the lessons we can learn from the RubyGems situation and how we can move forward. blog.peterzhu.ca/open-source-...

Open Source is the Most Fragile and Most Resilient Ecosystem - Peter Zhu

Some of my thoughts on the lessons we can learn from the RubyGems situation and how we can move forward.

blog.peterzhu.ca

4 11 40

Janko Marohnić @janko.io · 13d

If anyone using @zed.dev has also been experiencing empty symbol search results from Ruby LSP, please give this a 👍

github.com/zed-industri...

Zed excluding Ruby LSP results from project symbol search · Issue #40294 · zed-industries/zed

Summary Searching Ruby symbols in a project often shows empty results. Description When I'm trying to search project symbols, even though Ruby LSP server returns the results, Zed doesn't display th...

github.com

1 1

Janko Marohnić @janko.io · 15d

I started by feeding RPC messages between Zed and stimulus-language-server into Claude Code, which successfully reproduced the bug with a Node script, taking Zed out of the equation.

From there it was able to find the stimulus-parser bug, so I could eliminate LSP as well 😌

1

Janko Marohnić @janko.io · 15d

I was trying out Stimulus LSP in Zed, and was consistently seeing duplicates in controller autocompletion.

I didn't know whether the bug was in Zed, the Zed extension for Stimulus, Stimulus LSP or stimulus-parser 😅

It seems like it was the latter – github.com/marcoroth/st...

Registered controllers get duplicated after calling `Project.refresh()` · Issue #402 · marcoroth/stimulus-parser

I've been trying out Stimulus LSP in Zed editor, and have consistently been seeing duplicate controller names in the autocompletion box. I've tracked it down by looking at RCP messages, and saw Zed...

github.com

1