Lightnews — Scholar-powered news

Dominik 🔮

@tkdodo.eu

8.5K followers 420 following 1.8K posts

⚛️ Maintaining TanStack Query 🔮 https://query.gg 👨‍💻 Software Engineer @sentry.io 📚 Blog at https://tkdodo.eu 🇦🇹 Vienna, Austria 👧👦 Father of two

query.gg

Posts Media Videos Starter Packs

Pinned

Dominik 🔮 @tkdodo.eu · Nov 19

📢 After more than 11 years of working at Adverity in various positions, I’ve decided to look for new challenges in 2025.

🚀 I'm excited to share that starting in January, I'll be joining the Frontend Platform Team at @sentry.io.

68 12 590

Dominik 🔮 @tkdodo.eu · 51m

Share it, share it!

1 1

Reposted by Dominik 🔮

Open Source Pledge ⇌ @opensourcepledge.com · 13h

A year ago, @sentry.io launched the Open Source Pledge, with one singular goal: get maintainers paid.

A key pillar of the Pledge is it’s not a “pledge”, like an IOU. Rather, to join the Pledge, members come with receipts. Here’s why.

🧵

Nasdaq Tower in Times Square NYC.

The tower (which is covered in LEDs) reads
NASDAQ CELEBRATES ONE YEAR OF THE OPEN SOURCE PLEDGE AND THE COMPANIES WHO PAY MAINTAINERS

Below the text are all the member logos of companies who are members. The full list of member companies can be found here: https://opensourcepledge.com/members/

2 7 21

Dominik 🔮 @tkdodo.eu · 17h

does the PR look good? I mean the ts-expect-error is just nasty but I guess the plugin is just faulty?

1 1

Dominik 🔮 @tkdodo.eu · 17h

The rules also weren't really 1:1 on quality as we found out when migrating back. For example, prefer-optional-chain in eslint had _a lot_ better results than in biome as you can see on the migration PR:

chore: remove biome by natemoo-re · Pull Request #85552 · getsentry/sentry

See getsentry/frontend-tsc#67 for more details. We've had numerous discussions about Biome vs ESLint in the Frontend TSC. Biome is in a half-implemented state and having multiple linters is a f...

github.com

Dominik 🔮 @tkdodo.eu · 17h

Where things mainly fell apart for Biome was editor integration. VsCode & IntelliJ just didn't support Biome well enough, it crashed on multiple users for no apparent reason.

1 2

Dominik 🔮 @tkdodo.eu · 17h

Query never used biome, sentry did, and I wasn't much involved in that.

Oxlint is very promising but the tradeoff of shimming TypeScript's internal APIs seems a bit risky.

4 1

Dominik 🔮 @tkdodo.eu · 17h

This is the most professionally comment I've ever made 🤪

Dominik 🔮 @tkdodo.eu · 17h

I guess most people write their config files in js?

Dominik 🔮 @tkdodo.eu · 18h

This errors in TypeScript, but works at runtime 🤷‍♂️

Dominik 🔮 @tkdodo.eu · 18h

what a chore

a cartoon of a man with the words what a week huh written above him

Alt: a cartoon of a man with the words what a week huh written above him

media.tenor.com

Dominik 🔮 @tkdodo.eu · 18h

// @ts-expect-error wtf

github.com/TanStack/que...

chore: update eslint-plugin-react-hooks by TkDodo · Pull Request #9737 · TanStack/query

what a chore

github.com

5 8

Dominik 🔮 @tkdodo.eu · 18h

If you don’t use defineConfig (which I don’t, why should I, these are just arrays) then extends doesn’t work.

what does work at runtime is:

export default [
...reactHooks.configs['recommended-latest'],
]

it just errors on type level

Dominik 🔮 @tkdodo.eu · 18h

I’m manually defining all rules now because the presets either don’t work or at the least have type errors. The recommended preset actually has no compiler rules and you’d need recommended-latest. I wasted over an hour on this. Not great, @no.lol FYI

{
name: 'plugin/react-hooks',
plugins: { 'react-hooks': reactHooks },

rules: {
'react-hooks/exhaustive-deps': 'error',
'react-hooks/rules-of-hooks': 'error',
'react-hooks/static-components': 'error',
'react-hooks/use-memo': 'error',
'react-hooks/component-hook-factories': 'error',
'react-hooks/preserve-manual-memoization': 'error',
'react-hooks/incompatible-library': 'error',
'react-hooks/immutability': 'error',
'react-hooks/globals': 'error',
'react-hooks/refs': 'error',
'react-hooks/set-state-in-effect': 'error',
'react-hooks/error-boundaries': 'error',
'react-hooks/purity': 'error',
'react-hooks/set-state-in-render': 'error',
'react-hooks/unsupported-syntax': 'error',
'react-hooks/config': 'error',
'react-hooks/gating': 'error',
},
},

1 13

Dominik 🔮 @tkdodo.eu · 18h

how on earth is this so complicated lol

Dominik 🔮 @tkdodo.eu · 18h

how do I add add the preset? this doesn’t work:

extends: ['react-hooks/recommended'],

Dominik 🔮 @tkdodo.eu · 19h

That’s a monorepo issue. It works with `typescript.config` when installing typescript-eslint

import typescript from 'typescript-eslint'
export default typescript.config([...])

but still no dice on the config itself

Dominik 🔮 @tkdodo.eu · 19h

How is reactHooks imported? I get errors left and right:

import reactHooks from 'eslint-plugin-react-hooks'

{
extends: [reactHooks.configs['recommended-latest']],
},

TS2339: Property configs does not exist on type

Dominik 🔮 @tkdodo.eu · 19h

I’m stuck on this now:

TypeError: Key "rules": Key "react-hooks/react-compiler": Could not find "react-compiler" in plugin "react-hooks".

not sure why? This doesn’t work anymore:

'react-hooks/rules-of-hooks': 'error',

Dominik 🔮 @tkdodo.eu · 19h

why would I need either one? Up until now, we just return an Array: github.com/TanStack/que...

github.com

2 1

Dominik 🔮 @tkdodo.eu · 19h

of course AI is useless and just drops even worse suggestions all the time 🙄

Dominik 🔮 @tkdodo.eu · 19h

even if I 1:1 copy the eslint config as it is, it just yields “Parsing error: Unexpected token {“ on every type import 😭

1 2

Dominik 🔮 @tkdodo.eu · 19h

Alternating between this:

TypeError: Key "rules": Key "react-hooks/react-compiler": Could not find "react-compiler" in plugin "react-hooks".

and this:

Oops! Something went wrong! :(
A config object is using the "extends" key, which is not supported in flat config system.

2 2

Dominik 🔮 @tkdodo.eu · 19h

Having the _worst_ time trying to upgrade eslint-plugin-react-hooks to v6.1.1 in the Query repo. Why are the instructions for flat config so weird? What’s defineConfig? Why do I get TypeError: Unexpected array?

This shouldn’t be more complicated than adding ONE line of code to the eslint.config.js

www.npmjs.com

9 21

Dominik 🔮 @tkdodo.eu · 19h

we already bundle

Dominik 🔮 @tkdodo.eu · 20h

auto-memoization even for users who don't use the compiler on their projects